a3fbfae82b4cb3ff9928e29f34c64d0507cad874 is the first bad commit commit a3fbfae82b4cb3ff9928e29f34c64d0507cad874 Author: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> Date: Mon Nov 5 02:07:56 2018 +0200
tpm: take TPM chip power gating out of tpm_transmit() Call tpm_chip_start() and tpm_chip_stop() in * tpm_chip_register() * tpm_class_shutdown() * tpm_del_char_device() * tpm_pm_suspend() * tpm_try_get_ops() and tpm_put_ops() * tpm2_del_space() And remove these calls from tpm_transmit(). The core reason for this change is that in tpm_vtpm_proxy a locality change requires a virtual TPM command (a command made up just for that driver). The consequence of this is that this commit removes the remaining nested calls. Signed-off-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> Reviewed-by: Stefan Berger <stef...@linux.ibm.com> Tested-by: Stefan Berger <stef...@linux.ibm.com> Reviewed-by: Jerry Snitselaar <jsnit...@redhat.com> Reviewed-by: James Bottomley <james.bottom...@hansenpartnership.com> Tested-by: Alexander Steffen <alexander.stef...@infineon.com> drivers/char/tpm/tpm-chip.c | 38 ++++++++++++++++++++++---------------- drivers/char/tpm/tpm-interface.c | 18 +++++++++--------- drivers/char/tpm/tpm.h | 9 --------- drivers/char/tpm/tpm2-space.c | 5 ++++- drivers/char/tpm/tpm_tis_core.c | 4 ++++ drivers/char/tpm/tpm_vtpm_proxy.c | 3 +-- 6 files changed, 40 insertions(+), 37 deletions(-) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1891502 Title: tpm tpm0: Error (28) sending savestate before suspend Status in linux package in Ubuntu: Incomplete Bug description: Upon clicking suspend via Log Out... button in Xubuntu and also via systemctl suspend, the screen turns to black for 2 sec but then brings me back to log in screen instead of suspending. This was not an issue in 18.04. Currently on fresh install of 20.04.1. Aug 13 08:12:59 laptop kernel: [87528.628302] PM: suspend entry (s2idle) Aug 13 08:13:00 laptop kernel: [87529.250844] printk: Suspending console(s) (use no_console_suspend to debug) Aug 13 08:13:00 laptop kernel: [87529.250844] printk: Suspending console(s) (use no_console_suspend to debug) Aug 13 08:13:00 laptop kernel: [87529.555272] tpm tpm0: Error (28) sending savestate before suspend Aug 13 08:13:00 laptop kernel: [87529.555287] PM: __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x80 returns 28 Aug 13 08:13:00 laptop kernel: [87529.555292] PM: dpm_run_callback(): pnp_bus_suspend+0x0/0x20 returns 28 Aug 13 08:13:00 laptop kernel: [87529.555296] PM: Device 00:01 failed to suspend: error 28 Aug 13 08:13:00 laptop kernel: [87529.929361] PM: Some devices failed to suspend, or early wake event detected Aug 13 08:13:01 laptop kernel: [87530.458095] PM: suspend exit Aug 13 08:13:01 laptop systemd[1]: systemd-suspend.service: Succeeded. ProblemType: Bug DistroRelease: Ubuntu 20.04 Package: linux-image-5.4.0-42-generic 5.4.0-42.46 ProcVersionSignature: Ubuntu 5.4.0-42.46-generic 5.4.44 Uname: Linux 5.4.0-42-generic x86_64 ApportVersion: 2.20.11-0ubuntu27.6 Architecture: amd64 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: smrtalec 1174 F.... pulseaudio CasperMD5CheckResult: skip CurrentDesktop: XFCE Date: Thu Aug 13 08:25:19 2020 InstallationDate: Installed on 2020-08-10 (2 days ago) InstallationMedia: Ubuntu 20.04.1 LTS "Focal Fossa" - Release amd64 (20200731) MachineType: Hewlett-Packard HP Compaq 2510p Notebook PC PccardctlIdent: Socket 0: no product info available PccardctlStatus: Socket 0: no card ProcFB: 0 i915drmfb ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.4.0-42-generic root=UUID=bf5ecda3-8bba-45a8-8f73-038836aa1952 ro quiet splash vt.handoff=7 RelatedPackageVersions: linux-restricted-modules-5.4.0-42-generic N/A linux-backports-modules-5.4.0-42-generic N/A linux-firmware 1.187.2 SourcePackage: linux UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 11/11/2011 dmi.bios.vendor: Hewlett-Packard dmi.bios.version: 68MSP Ver. F.30 dmi.board.name: 30C9 dmi.board.vendor: Hewlett-Packard dmi.board.version: KBC Version 75.28 dmi.chassis.type: 10 dmi.chassis.vendor: Hewlett-Packard dmi.modalias: dmi:bvnHewlett-Packard:bvr68MSPVer.F.30:bd11/11/2011:svnHewlett-Packard:pnHPCompaq2510pNotebookPC:pvrF.30:rvnHewlett-Packard:rn30C9:rvrKBCVersion75.28:cvnHewlett-Packard:ct10:cvr: dmi.product.family: 103C_5336AN dmi.product.name: HP Compaq 2510p Notebook PC dmi.product.sku: KR918UT#ABA dmi.product.version: F.30 dmi.sys.vendor: Hewlett-Packard To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1891502/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp