** Description changed: - == Comment: #0 - VASANT HEGDE <hegdevas...@in.ibm.com> - 2020-09-02 01:00:25 == - --Problem Description--- - Do not initiate shutdown for EPOW_SHUTDOWN_ON_UPS event. Instead wait for predefined time before initiating shtudown. - - Contact Information = Vasant hegde <hegdevas...@linux.vnet.ibm.com? - - ---uname output--- - Ubuntu 16.04 - - Machine Type = All Power System + SRU Justification: - Upstream commit : - commit 90a9b102eddf6a3f987d15f4454e26a2532c1c98 - Author: Vasant Hegde <hegdevas...@linux.vnet.ibm.com> - Date: Thu Aug 20 11:48:44 2020 +0530 + [Impact] - powerpc/pseries: Do not initiate shutdown when system is running on UPS - + * With commit 79872e35469b "powerpc/pseries: All events of + EPOW_SYSTEM_SHUTDOWN must initiate shutdown" it was introduced that all + EPOW_SYSTEM_SHUTDOWN events cause immediate shutdowns. - Note that I have requested this fix for upstream v4.4 stable tree. This - will hit stable tree soon. + * But on LPARs there is a user space tool (rtas_errd) that monitor for + EPOW_SHUTDOWN_ON_UPS events. - This is impacting all kernel after v4.0. This is critical fix. Hence - I'd like to request to backport to Ubuntu 16.04 LTS release. + * Once rtas_errd gets an event it initiates a shutdown after predefined + time. + * Therefore immediate shutdowns must not be triggered if the system is + running on UPS (means for EPOW_SHUTDOWN_ON_UPS events). - -Vasant + [Fix] + + * 90a9b102eddf6a3f987d15f4454e26a2532c1c98 90a9b102eddf + "powerpc/pseries: Do not initiate shutdown when system is running on + UPS" + + [Test Case] + + * Setup a Power system on (D)LPAR and run it on UPS with Ubuntu 16.04 or + higher (kernel 4.x is needed). + + * Verify that the user space tool (rtas_errd) is active and running. + + * Define a time for a potential shutdown in case an EPOW_SHUTDOWN_ON_UPS + event occurs. + + * Trigger an EPOW_SHUTDOWN_ON_UPS event. + + * Verify if the system got shutdown immediately - or after the pre- + defined time. + + [Regression Potential] + + * The regression risk is very low, because of the very limited + modification in a case statement for EPOW_SHUTDOWN_ON_UPS events. + + * What may happen is that the system doesn't power off anymore if + running on UPS due to the EPOW_SHUTDOWN_ON_UPS case changes - especially + if there is a potential problem with rtas_errd that should monitor for + these events and should initiate the delayed shutdown. + + * Other than that I cannot see much potential harm. + + [Other] + + * The patch got upstream accepted in v5.9-rc2 and already landed in + groovy's kernel 'Ubuntu-5.8.0-18.19', based on the v5.8.4 upstream + stable release ticket LP 1893048.
-- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1893897 Title: [Regression] Do not initiate shutdown for EPOW_SHUTDOWN_ON_UPS event Status in The Ubuntu-power-systems project: In Progress Status in linux package in Ubuntu: Fix Released Status in linux source package in Xenial: New Status in linux source package in Bionic: New Status in linux source package in Focal: New Status in linux source package in Groovy: Fix Released Bug description: SRU Justification: [Impact] * With commit 79872e35469b "powerpc/pseries: All events of EPOW_SYSTEM_SHUTDOWN must initiate shutdown" it was introduced that all EPOW_SYSTEM_SHUTDOWN events cause immediate shutdowns. * But on LPARs there is a user space tool (rtas_errd) that monitor for EPOW_SHUTDOWN_ON_UPS events. * Once rtas_errd gets an event it initiates a shutdown after predefined time. * Therefore immediate shutdowns must not be triggered if the system is running on UPS (means for EPOW_SHUTDOWN_ON_UPS events). [Fix] * 90a9b102eddf6a3f987d15f4454e26a2532c1c98 90a9b102eddf "powerpc/pseries: Do not initiate shutdown when system is running on UPS" [Test Case] * Setup a Power system on (D)LPAR and run it on UPS with Ubuntu 16.04 or higher (kernel 4.x is needed). * Verify that the user space tool (rtas_errd) is active and running. * Define a time for a potential shutdown in case an EPOW_SHUTDOWN_ON_UPS event occurs. * Trigger an EPOW_SHUTDOWN_ON_UPS event. * Verify if the system got shutdown immediately - or after the pre- defined time. [Regression Potential] * The regression risk is very low, because of the very limited modification in a case statement for EPOW_SHUTDOWN_ON_UPS events. * What may happen is that the system doesn't power off anymore if running on UPS due to the EPOW_SHUTDOWN_ON_UPS case changes - especially if there is a potential problem with rtas_errd that should monitor for these events and should initiate the delayed shutdown. * Other than that I cannot see much potential harm. [Other] * The patch got upstream accepted in v5.9-rc2 and already landed in groovy's kernel 'Ubuntu-5.8.0-18.19', based on the v5.8.4 upstream stable release ticket LP 1893048. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1893897/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
