------- Comment From tmri...@de.ibm.com 2022-06-20 04:48 EDT-------
I have installed kernel version
# uname -a
Linux a35lp67 5.13.0-52-generic #59-Ubuntu SMP Wed Jun 15 20:16:44 UTC 2022 
s390x s390x s390x GNU/Linux
and can confirm that the z16 Extended counter set counters are available on 
that system:

# cd /sys/devices/cpum_cf/events; ls -l | fgrep DCW

-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_OFF_DRAWER_MEMORY
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_CHIP
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_CHIP_CHIP_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_CHIP_DRAWER_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_CHIP_IV
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_CHIP_MEMORY
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_DRAWER
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_DRAWER_MEMORY
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_MODULE
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_ON_MODULE_MEMORY
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_REQ
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_REQ_CHIP_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_REQ_DRAWER_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 DCW_REQ_IV
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_OFF_DRAWER_CHIP_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_OFF_DRAWER_DRAWER_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_OFF_DRAWER_IV
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_ON_DRAWER_CHIP_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_ON_DRAWER_DRAWER_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_ON_DRAWER_IV
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_ON_MODULE_CHIP_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_ON_MODULE_DRAWER_HIT
-r--r--r-- 1 root root 4096 Jun 20 10:43 IDCW_ON_MODULE_IV

Verification ok and successful

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1974433

Title:
  [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new
  IBM z16

Status in Ubuntu on IBM z Systems:
  Fix Committed
Status in linux package in Ubuntu:
  Invalid
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Impish:
  Fix Committed
Status in linux source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:
  ==================

  [Impact]

   * This is a hardware enablement SRU

   * and adds support for (new) IBM z16 counters

   * by exporting the extended counter set counters of the IBM z16 via
  sysfs.

  [Fix]

   * c9311de71635 c9311de71635d3eaa158df8516b9b99a92d60a0c
     "s390/cpumf: add new extended counter set for IBM z16"

  [Test Case]

   * Prepare an IBM z16 LPAR with Ubuntu 20.04, 21.10 or 22.04 (incl.
  this patch).

   * At LPARs activation profile, navigate to the Security page
     and within the counter facility options, select each counter set you want 
to use.
     (One may just select all for testing purposes.)

   * Use 'perf list' to determine if the new counters are listed.
     For comparing the new counters see:
     https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git\
     /commit/?id=c9311de71635d3eaa158df8516b9b99a92d60a0c

   * Use 'perf stat -e' to enable and make use of these counters.

  [What can go wrong]

   * Only new code is added by this commit - none is changed nor
  removed.

   * The new code may have syntactical errors,
     which would become visible during a test compile.

   * Initialization of the new struct cpumcf_z16_pmu_event_attr could be
  wrong.

   * The hex code for the counters could be wrong or mixed up,
     or the names might be wrong or mixed up,
     in which case one will get wrong or unexpected results.

   * The expansion of the case statement to determine the correct (z16) hardware
     might be wrong, using wrong case hex numbers.
     Which would lead to potentially counters,
     that may not match to the underlying hardware.

  [ Other info]

   * The commit will be upstream accepted with 5.18.
     (It's was brought upstream 'next-20220517'.)

   * Since the planned target kernel for kinetic is 5.19,
     this will be included.

   * Hence the SRU is for Focal, Impish and Jammy only.

  __________

  For IBM z16 machine the extended counter set needs to be exported by the PMU 
device driver CPU MF. The upstream commit from linux-next is
  commit-id: c9311de71635 s390/cpumf: add new extended counter set for IBM z16

  The same patch will be imported into linux repo in the next merge
  window.

  Required patches are attached. They apply cleanly and compile without
  errors on focal (20.04) and jammy (22.04).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to