Launchpad has imported 1 comments from the remote bug at https://bugzilla.kernel.org/show_bug.cgi?id=216460.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2022-09-07T18:42:48+00:00 mario.limonciello wrote: The firmware-attributes documentation ( https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class- firmware-attributes) indicates that all drivers that support firmware- attributes need to support the 'type' attribute. This is important for userspace software to know how to interact with the driver. fwupd 1.8.4 added support for the firmware-attributes class API, but since lenovo-thinklmi doesn't meet it shows the following error on every boot. KERNEL BUG: 'type' attribute not exported: (failed to load type: Failed to open file “/sys/class/firmware- attributes/thinklmi/attributes/MCRUSBHeader/type”: No such file or directory) A workaround has been landed in fwupd to avoid this attribute and hardcode the known behavior of the current driver when it finds it. It seems like all the attributes are actually "enumeration", so the lenovo-thinklmi kernel driver should probably just export a type sysfs file with "enumeration" hardcoded for all attributes. Also though, the possible_values key is not populated either. Instead the values are put into the "current_value" string. On a Lenovo P620 the following happens: $ sudo cat /sys/class/firmware-attributes/thinklmi/attributes/NUMA/current_value Auto;[Optional:NPS1,NPS2,NPS4,Auto] $ sudo cat /sys/class/firmware-attributes/thinklmi/attributes/NUMA/possible_values cat: /sys/class/firmware-attributes/thinklmi/attributes/NUMA/possible_values: Operation not supported That is the userspace software tears apart the current_value string and instead puts it into what the possible_values are. This should be the responsibility of the kernel driver. Even if the firwmare returns all that in current_value, the kernel driver should be doing the splitting so that userspace doesn't need to carry quirks for different kernel drivers behaving differently. Reply at: https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1990052/comments/0 ** Changed in: linux Status: Unknown => Confirmed ** Changed in: linux Importance: Unknown => Medium -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1990052 Title: fwupdtool reports an error (KERNEL BUG) when refreshing Status in Linux: Confirmed Status in fwupd package in Ubuntu: Invalid Status in linux package in Ubuntu: Triaged Bug description: when running the "refresh" command I get the following message $ sudo fwupdtool refresh Loading… [************************** ]07:43:19:0893 FuBiosSettings KERNEL BUG: 'type' attribute not exported: (failed to load type: Failed to open file “/sys/class/firmware-attributes/thinklmi/attributes/TotalMemoryEncryption/type”: No such file or directory) Loading… [- ] Downloading… [***************************************] Downloading… [***************************************] Downloading… [************************************** ] Not sure if it's just a warning or an actual error. ProblemType: Bug DistroRelease: Ubuntu 22.10 Package: fwupd 1.8.4-2 ProcVersionSignature: Ubuntu 5.19.0-16.16-generic 5.19.7 Uname: Linux 5.19.0-16-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.23.0-0ubuntu1 Architecture: amd64 CasperMD5CheckResult: pass CurrentDesktop: GNOME Date: Sun Sep 18 09:43:50 2022 InstallationDate: Installed on 2022-09-11 (6 days ago) InstallationMedia: Ubuntu 22.10 "Kinetic Kudu" - Alpha amd64 (20220829) SourcePackage: fwupd UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/linux/+bug/1990052/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
