** Description changed:

  SRU Justification:
  
  [Impact]
  
  Several i2c-mlxbf.c patches have been upstreamed recently and are in
  linux-next at the moment. So revert all changes in both Focal (5.4) and
  Jammy (5.15) and cherry-pick all changes from linux-next master.
  
- IMPORTANT NOTE: please make sure you also load the latest UEFI (EDK2)
- firmware because there are dependencies.
+ IMPORTANT NOTE: The new linux i2c support for BF3 also REQUIRES
+ upgrading the UEFI firmware version. For BF1 and BF2 however, this
+ driver should be backward compatible with older UEFI versions.
  
  [Fix]
  
  * There is a total of 17 commits: 8 reverts, 8 cherry-picks from linux-
  next and one internal "UBUNTU: SAUCE:" to ad the driver version.
  Following is the list of commits cherry-picked.
  
  * i2c: mlxbf: incorrect base address passed during io write
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2a5be6d1340c0fefcee8a6489cff7fd88a0d5b85>
  
  * i2c: mlxbf: prevent stack overflow in mlxbf_i2c_smbus_start_transaction()
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=de24aceb07d426b6f1c59f33889d6a964770547b>
  
  * i2c: mlxbf: remove IRQF_ONESHOT
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=92be2c122e495f0249090c0048f4fd05fe1efa9e>
  
  * i2c: mlxbf: Fix frequency calculation
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=37f071ec327b04c83d47637c5e5c2199b39899ca>
  
  * i2c: mlxbf: support lock mechanism
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=86067ccfa1424a26491542d6f6d7546d40b61a10>
  
  * i2c: mlxbf: add multi slave functionality
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bdc4af281b70b7fe2881fd08f1aa1b15f2b6adf0>
  
  * i2c: mlxbf: support BlueField-3 SoC
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=19e13e1330c63506452eed80f473f344e6779b94>
  
  * i2c: mlxbf: remove device tree support
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=be18c5ede25da39a0eda541f6de3620a30cf731f>
  
  * Also add the i2c driver version to keep track of the changes
  internally.
  
  [Test Case]
  
  * Check that the i2c driver loads without errors on BF1 and BF2 (dmesg, and 
check i2c1 sysfs is created)
  * Check that the i2c module can be removed and reloaded without errors.
  * Check that IPMB services work successfully on systems with BMC. This is the 
best way to test the i2c driver. Run ipmitool command from the BF: ipmitool mc 
info
  * Run ipmitool from the BMC as well: ipmitool -I ipmb mc info
+ * This driver should be backward compatible
+ * Make sure this driver is backward compatible with older UEFI version (only 
applicable for BF1 and BF2)
+ * Make sure this driver works for BF1, BF2 and BF3 with the latest UEFI 
version.
  
  [Regression Potential]
  
  * The i2c driver could fail to load because the UEFI firmware hasn't been 
upgraded
  * The i2c driver would fail to load due to a bug
  * IPMB code which utilises the i2c driver fails to work (ipmitool commands)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1991551

Title:
  i2c-mlxbf.c: Sync up driver with upstreaming

Status in linux-bluefield package in Ubuntu:
  New

Bug description:
  SRU Justification:

  [Impact]

  Several i2c-mlxbf.c patches have been upstreamed recently and are in
  linux-next at the moment. So revert all changes in both Focal (5.4)
  and Jammy (5.15) and cherry-pick all changes from linux-next master.

  IMPORTANT NOTE: The new linux i2c support for BF3 also REQUIRES
  upgrading the UEFI firmware version. For BF1 and BF2 however, this
  driver should be backward compatible with older UEFI versions.

  [Fix]

  * There is a total of 17 commits: 8 reverts, 8 cherry-picks from
  linux-next and one internal "UBUNTU: SAUCE:" to ad the driver version.
  Following is the list of commits cherry-picked.

  * i2c: mlxbf: incorrect base address passed during io write
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2a5be6d1340c0fefcee8a6489cff7fd88a0d5b85>

  * i2c: mlxbf: prevent stack overflow in mlxbf_i2c_smbus_start_transaction()
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=de24aceb07d426b6f1c59f33889d6a964770547b>

  * i2c: mlxbf: remove IRQF_ONESHOT
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=92be2c122e495f0249090c0048f4fd05fe1efa9e>

  * i2c: mlxbf: Fix frequency calculation
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=37f071ec327b04c83d47637c5e5c2199b39899ca>

  * i2c: mlxbf: support lock mechanism
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=86067ccfa1424a26491542d6f6d7546d40b61a10>

  * i2c: mlxbf: add multi slave functionality
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bdc4af281b70b7fe2881fd08f1aa1b15f2b6adf0>

  * i2c: mlxbf: support BlueField-3 SoC
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=19e13e1330c63506452eed80f473f344e6779b94>

  * i2c: mlxbf: remove device tree support
  From 
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=be18c5ede25da39a0eda541f6de3620a30cf731f>

  * Also add the i2c driver version to keep track of the changes
  internally.

  [Test Case]

  * Check that the i2c driver loads without errors on BF1 and BF2 (dmesg, and 
check i2c1 sysfs is created)
  * Check that the i2c module can be removed and reloaded without errors.
  * Check that IPMB services work successfully on systems with BMC. This is the 
best way to test the i2c driver. Run ipmitool command from the BF: ipmitool mc 
info
  * Run ipmitool from the BMC as well: ipmitool -I ipmb mc info
  * This driver should be backward compatible
  * Make sure this driver is backward compatible with older UEFI version (only 
applicable for BF1 and BF2)
  * Make sure this driver works for BF1, BF2 and BF3 with the latest UEFI 
version.

  [Regression Potential]

  * The i2c driver could fail to load because the UEFI firmware hasn't been 
upgraded
  * The i2c driver would fail to load due to a bug
  * IPMB code which utilises the i2c driver fails to work (ipmitool commands)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1991551/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to