Public bug reported:
s390/pci: Fix zpci_bus_is_isolated_vf() for non-VFs
Commit:
8691abd3afaadd816a298503ec1a759df1305d2e
-------------------------
For non-VFs, zpci_bus_is_isolated_vf() should return false
because they
aren't VFs. While zpci_iov_find_parent_pf() specifically checks if
a function is a VF, it then simply returns that there is no
parent. The
simplistic check for a parent then leads to these functions being
confused with isolated VFs and isolating them on their own domain
even
if sibling PFs should share the domain.
Fix this by explicitly checking if a function is not a VF. Note
also
that at this point the case where RIDs are ignored is already
handled
and in this case all PCI functions get isolated by being detected
in
zpci_bus_is_multifunction_root().
Cc: [email protected]
Fixes: 2844ddbd540f ("s390/pci: Fix handling of isolated VFs")
Signed-off-by: Niklas Schnelle <[email protected]>
Reviewed-by: Halil Pasic <[email protected]>
Signed-off-by: Vasily Gorbik <[email protected]>
** Affects: ubuntu-z-systems
Importance: High
Assignee: Skipper Bug Screeners (skipper-screen-team)
Status: New
** Affects: linux (Ubuntu)
Importance: High
Status: Invalid
** Affects: linux (Ubuntu Noble)
Importance: Undecided
Status: New
** Affects: linux (Ubuntu Oracular)
Importance: Undecided
Status: New
** Affects: linux (Ubuntu Plucky)
Importance: Undecided
Status: New
** Affects: linux (Ubuntu Questing)
Importance: High
Status: Invalid
** Tags: architecture-s39064 bugnameltc-213599 severity-high
targetmilestone-inin---
** Tags added: architecture-s39064 bugnameltc-213599 severity-high
targetmilestone-inin---
** Changed in: ubuntu
Assignee: (unassigned) => Skipper Bug Screeners (skipper-screen-team)
** Package changed: ubuntu => linux (Ubuntu)
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2111599
Title:
[UBUNTU 24.04] s390/pci: Fix zpci_bus_is_isolated_vf() for non-VF
Status in Ubuntu on IBM z Systems:
New
Status in linux package in Ubuntu:
Invalid
Status in linux source package in Noble:
New
Status in linux source package in Oracular:
New
Status in linux source package in Plucky:
New
Status in linux source package in Questing:
Invalid
Bug description:
s390/pci: Fix zpci_bus_is_isolated_vf() for non-VFs
Commit:
8691abd3afaadd816a298503ec1a759df1305d2e
-------------------------
For non-VFs, zpci_bus_is_isolated_vf() should return false
because they
aren't VFs. While zpci_iov_find_parent_pf() specifically checks
if
a function is a VF, it then simply returns that there is no
parent. The
simplistic check for a parent then leads to these functions
being
confused with isolated VFs and isolating them on their own
domain even
if sibling PFs should share the domain.
Fix this by explicitly checking if a function is not a VF. Note
also
that at this point the case where RIDs are ignored is already
handled
and in this case all PCI functions get isolated by being
detected in
zpci_bus_is_multifunction_root().
Cc: [email protected]
Fixes: 2844ddbd540f ("s390/pci: Fix handling of isolated VFs")
Signed-off-by: Niklas Schnelle <[email protected]>
Reviewed-by: Halil Pasic <[email protected]>
Signed-off-by: Vasily Gorbik <[email protected]>
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/2111599/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
