Em Thu, Jun 24, 2010 at 09:44:50AM -0400, Adam Jackson escreveu:
> On Tue, 2010-06-22 at 17:37 -0700, Roland McGrath wrote:
> >  %package -n perf
> >  Summary: Performance monitoring for the Linux kernel
> >  Group: Development/System
> >  License: GPLv2
> > +%if %{with_perftool}
> > +Requires: kernel-perf(%{_arch}) >= %{version}-%{release}
> > +%endif
> 
> Oughtn't this be:
> 
> Requires: kernel-perf%{_isa} >= %{version}-%{release}

The version-release part shouldn't be there, backward compatibility is a
goal, so one can use an arbitrary perf binary with an arbitrary kernel.

Features that are used in a perf binary, say, what is needed by 'perf
probe', when not present in a kernel, should just produce an error
message at runtime when people try to use 'perf probe'.

- Arnaldo
_______________________________________________
kernel mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/kernel

Reply via email to