On 06/13/2016 03:35 PM, Laura Abbott wrote:
> On 06/13/2016 11:41 AM, Josh Boyer wrote:
>> On Mon, Jun 13, 2016 at 2:32 PM, Prarit Bhargava <[email protected]> wrote:
>>> On 06/10/2016 03:42 PM, Miguel Flores Silverio wrote:
>>>> Signed-off-by: Miguel Flores Silverio <[email protected]>
>>>> ---
>>>>  scripts/fast-build.sh | 13 +++++++++++++
>>>>  1 file changed, 13 insertions(+)
>>>>  create mode 100755 scripts/fast-build.sh
>>>>
>>>> diff --git a/scripts/fast-build.sh b/scripts/fast-build.sh
>>>> new file mode 100755
>>>> index 0000000..19eaa4d
>>>> --- /dev/null
>>>> +++ b/scripts/fast-build.sh
>>>> @@ -0,0 +1,13 @@
>>>> +#! /bin/sh
>>>> +# Description:
>>>> +#     rpmbuild combo to build the given architecture with
>>>> +#     no debugging information, perf and tools.
>>>> +#
>>>> +# Sample usage:
>>>> +#     ./fast-build.sh x86_64 kernel-4.7.0-0.rc1.git1.2.fc25.src.rpm
>>>> +
>>>> +if [ -z "$1" ] || [ -z "$2" ]; then
>>>> +    echo "usage: $0 [ arch ] [ kernel-x.x.x.fcxx.src.rpm ] "
>>>> +fi
>>>> +
>>>> +rpmbuild --target $1 --without debuginfo --without perf --without tools
>>>> --rebuild $2
>>>> -- 
>>>
>>> Is the --target really necessary?  Why not just do $(arch)?
>>

$(arch) should return the native target.

I was assuming that the script would only be run natively ... but Laura brings
up the important case of x86 64-bit vs 32-bit.

> 
> Yes. Having a quick build shortcut reduces the burden on users building
> their own kernel.

Agreed (although I reserve the right to complain about minuscule things in
future and have jboyer ignore those too :) :) ).

P.

> 
> Thanks,
> Laura
> _______________________________________________
> kernel mailing list
> [email protected]
> https://lists.fedoraproject.org/admin/lists/[email protected]
_______________________________________________
kernel mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to