On 8/5/20 1:24 PM, GitLab Bridge on behalf of jeremycline wrote:
> From: Fedora Kernel Team <[email protected]>
> 
> Hi,
> 
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
> 
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
> 
> If the value for a file that is added should be changed, please reply
> with a better option.
> 
>  CONFIG_RD_ZSTD:
> 
>  Support loading of a ZSTD encoded initial ramdisk or cpio buffer.
>  If unsure, say N.
> 
>  Symbol: RD_ZSTD [=y]
>  Type  : bool
>  Defined at usr/Kconfig:103
>    Prompt: Support initial ramdisk/ramfs compressed using ZSTD
>    Depends on: BLK_DEV_INITRD [=y]
>    Location:
>      -> General setup
>        -> Initial RAM filesystem and RAM disk (initramfs/initrd) support 
> (BLK_DEV_INITRD [=y])
>  Selects: DECOMPRESS_ZSTD [=y]

This should be "N" given that we are disabling CONFIG_KERNEL_ZSTD in a previous
config patch.  Please change to "is not set".

Nacked-by: Prarit Bhargava <[email protected]>

P.

> 
> ---
> 
> Signed-off-by: Fedora Kernel Team <[email protected]>
> ---
>  redhat/configs/common/generic/CONFIG_RD_ZSTD   |  1 +
>  .../pending-common/generic/CONFIG_RD_ZSTD      | 18 ------------------
>  2 files changed, 1 insertion(+), 18 deletions(-)
>  create mode 100644 redhat/configs/common/generic/CONFIG_RD_ZSTD
>  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_RD_ZSTD
> 
> diff --git a/redhat/configs/common/generic/CONFIG_RD_ZSTD 
> b/redhat/configs/common/generic/CONFIG_RD_ZSTD
> new file mode 100644
> index 000000000000..da1496ccb2e2
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_RD_ZSTD
> @@ -0,0 +1 @@
> +CONFIG_RD_ZSTD=y
> diff --git a/redhat/configs/pending-common/generic/CONFIG_RD_ZSTD 
> b/redhat/configs/pending-common/generic/CONFIG_RD_ZSTD
> deleted file mode 100644
> index d3164499b7e0..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_RD_ZSTD
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -# CONFIG_RD_ZSTD:
> -# 
> -# Support loading of a ZSTD encoded initial ramdisk or cpio buffer.
> -# If unsure, say N.
> -# 
> -# Symbol: RD_ZSTD [=y]
> -# Type  : bool
> -# Defined at usr/Kconfig:103
> -#   Prompt: Support initial ramdisk/ramfs compressed using ZSTD
> -#   Depends on: BLK_DEV_INITRD [=y]
> -#   Location:
> -#     -> General setup
> -#       -> Initial RAM filesystem and RAM disk (initramfs/initrd) support 
> (BLK_DEV_INITRD [=y])
> -# Selects: DECOMPRESS_ZSTD [=y]
> -# 
> -# 
> -# 
> -CONFIG_RD_ZSTD=y
> 
_______________________________________________
kernel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to