On Mon, Aug 24, 2020 at 09:31:53AM -0500, Justin Forbes wrote: > > Right. rh-configs and fedora-configs are nice in that they build ONLY those > > configs. > > > I don't see a problem with having them broken out for specific cases, > but really by default people should be in the habit of build/check for > both. if you break one, you break everything.
Here is my thinking on this. The problem is really _time_. For a large majority of the use cases, developers are not engaging in make config changes. They just want to create them and start hacking. For that case, we should aim to be as quick as possible. I mean generating the configs is slower than what people expect. However, as part of an MR verification process, we _should_ check. We should run 'make dist-check-configs' as part of the CI to catch anything. Nothing should be merged unless it passes that check for the exact reasons you provided. Now once developers get burned a few times, they will learn to run that command locally before submitting an MR. And that is easy to do. For that reason, I have been leaning towards finding ways to speed up dist-configs and incorporate the full checks in gitlab-ci.yml. Thoughts? Cheers, Don _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
