On Mon, Nov 16, 2020 at 09:34:36PM -0000, GitLab Bridge on behalf of bcrocker 
wrote:
> +    merge-base )
> +        if [ -n "$EGIT_OVERRIDE_MERGE_BASE" ]
> +        then
> +            # This should be an SHA1:
> +            echo "$EGIT_OVERRIDE_MERGE_BASE"
> +        else
> +            git merge-base "$@"
> +        fi
> +        ;;
> +    * )
> +        git "$arg" "$@"
> +        ;;

Hi Ben, 

Can we drop the above piece?  You add it here, unused and then drop it in
the next patch.  Seems like unnecessary code churn.

Cheers,
Don
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org

Reply via email to