On Fri, 13 Nov 2020 21:12:20 -0000, GitLab Bridge on behalf of bcrocker wrote:
> -cat >${output} <<EOF
> +# We are generating, e.g., /lib/modules/<kernel>/bls.conf;
> +# bootprefix may legitimately be undefined here in this script:The comment seems to be off. Did you confuse $rootfs with $bootprefix? Should it be "We are generating e.g. /vmlinuz-<kernel>" instead? Anyway, the comment seems to be unnecessary. I don't think this is a valid check that the tool you're using does. It's reasonable to expect set +u and it's even necessary in this case, since it depends on environment variables. I think shellcheck is wrong here and I'm not much happy to see workarounds for broken shell checking tools. Could the # shellcheck disable= lines be at least accumulated somewhere and not be sprinkled throughout the script? Thanks, Jiri _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
