On Fri, 13 Nov 2020 21:12:22 -0000, GitLab Bridge on behalf of bcrocker wrote: > -STAMP=$(echo $MARKER | cut -f 1 -d '-' | sed -e "s/v//"); > +# STAMP=$(echo $MARKER | cut -f 1 -d '-' | sed -e "s/v//"); # unused
Good catch. Could you add a separate patch removing this line? A separate patch would be appropriate in this case, as it does a different thing than the rest of the patches, which try to not change the functionality. > -if [ "x$HIDE_REDHAT" == "x1" ]; then > - cat $clogf | grep -v -e "^- \[redhat\]" | > - sed -e 's!\[Fedora\]!!g' > $clogf.stripped > - cp $clogf.stripped $clogf > +if [ "x$HIDE_REDHAT" = "x1" ]; then Since you're touching this, could you delete the MS-DOS-era "x"? The variable is quoted and we can do empty strings just fine for a few decades :-) > -if [ "x$HIDE_UNSUPPORTED_ARCH" == "x1" ]; then > - cat $clogf | egrep -v "^- > \[(alpha|arc|arm|avr32|blackfin|c6x|cris|frv|h8300|hexagon|ia64|m32r|m68k|metag|microblaze|mips|mn10300|openrisc|parisc|score|sh|sparc|tile|um|unicore32|xtensa)\]" > > $clogf.stripped > - cp $clogf.stripped $clogf > +if [ "x$HIDE_UNSUPPORTED_ARCH" = "x1" ]; then And here, too. Thanks, Jiri _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
