On 3/2/22 07:03, Dan Horák wrote:
Hi,

would it be possible for the gitlab automation to generate diffs for the
"full" config files (kernel-$arch-*.config) when a MR is proposing
config changes (updates in redhat/config/*)? I think it would help
reviewing them, to see what are the effects of the proposed change(s) to
the generated config files.


Adding ptalbert & jarod.

Y'know, I had this exact same thought a while ago. It would be nice if we got a diff of the actual configs but I couldn't think of an easy way to do it.

It would require the webhooks to know about the "base" kernel build.

The webhooks would have to 'make dist-configs' in the base tree or rip the .configs from those rpms, and then compare them to the output of 'make dist-configs' from the MR tree.

That seemed really complicated so I didn't bother suggesting it. Perhaps jarod or ptalbert may know of a better solution?

P.
_______________________________________________
kernel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to