From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1642#note_886204441
@prarit - a couple of comments. based on internal discussions, we can see relying on HEAD to be a redhat tag commit may not work. In the same vein, when @ptalbert clicks 'Merge' through out the day and someone creates an MR off that merge, do we run into the same problem? Though the self-test seems isolated to dist-release, which makes the change fine because the expected output *is* a redhat tag commit. Second, the SRPM skip. self-tests are about controlled output. If someone makes a change to scripts or Makefile, then the self-tests needs to regenerate the srpm to verify the updated contents. If that is unnecessary and we are ok with the users srpm, then what is the point of the check? Assuming the users srpm is correct for self-tests is a bad idea. Either regenerate it or remove the check. _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
