From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2236#note_1219436857
I'm not familiar with the original problem, but familiar with rpminspect in
general. The problem is that the build of the tool does not respect the
CFLAGS/LDFLAGS given by rpm with hardening options etc., so later rpminspect
fails since the binaries were not built with proper cflags/ldflags.
In this case looking quickly here, there are two problems: the makefile
(tools/vm/Makefile) does not accept user specified CFLAGS, and for the
tools/lib/api that the slabinfo/page_owner_sort uses, that uses
tools/lib/api/Makefile which has EXTRA_CFLAGS usage...
So I think you need two options here to really fix this, something like this
patch:
```
$ git diff
diff --git a/tools/vm/Makefile b/tools/vm/Makefile
index 9860622cbb15..6c1da51f4177 100644
--- a/tools/vm/Makefile
+++ b/tools/vm/Makefile
@@ -8,8 +8,8 @@ TARGETS=page-types slabinfo page_owner_sort
LIB_DIR = ../lib/api
LIBS = $(LIB_DIR)/libapi.a
-CFLAGS = -Wall -Wextra -I../lib/
-LDFLAGS = $(LIBS)
+CFLAGS += -Wall -Wextra -I../lib/
+LDFLAGS += $(LIBS)
all: $(TARGETS)
```
Then you can build the tools with:
EXTRA_CFLAGS="${RPM_OPT_FLAGS}" %{tools_make} slabinfo page_owner_sort
You can verify that the proper flags are being used passing V=1, for example:
EXTRA_CFLAGS="${RPM_OPT_FLAGS}" %{tools_make} V=1 slabinfo page_owner_sort
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
