From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2262#note_1258074197

Looks like this part doesn't translate exactly what the perl part implemented:

```
        if (defined($configname) && !exists($configvalues{$configname})) {
                $configvalues{$configname} = $str;
                $configoptions[$configcounter] = $configname;
                $configcounter ++;
        }
```

If the overrides file has the same config option listed twice, the perl seemed
to ignore it. Eg.

CONFIG_FOO = y
CONFIG_FOO = n

configvalues gets CONFIG_FOO = y
next iteration configvalues is not assigned because CONFIG_FOO is already
assigned previously

The python script is not checking this, always assign what it reads
(```overrides[c] = line```)

Not sure if this is a real problem or not, but just pointing out. We can
resolve this thread if it's not an issue.
_______________________________________________
kernel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to