From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1753782383
Looking at this config file, I'm not entirely convinced that we benefit from having this in a config file, and it has downsides in lack of flexibility. For example, consider that as we expand UKIs to multiple architectures, we'll almost certainly need to have different addons on each arch. We could create extra config files per arch for those, but the amount of info in the file doesn't appear all that compelling. Consider if the python tool just accepted the data on the cli: ``` # Enable fips in RHEL (https://issues.redhat.com/browse/RHEL-23049) python3 ukiaddon.py --output $KernelAddonsDir/fips.addon --cmdline "fips=1" ``` Then each invokation of ukiaddon.py can be conditionalized based on whatever rpm spec conditions are needed. -- _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
