From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2913#note_1781333867

create-data.sh now calls the setup_source make target, which calls dist-clean-
sources.  The dist-clean-sources skips the cleanup due to being wrapped with
ifndef RHSELFTESTDATA.  One thing that bothers me, is the description above
the ifndef line:

```# skip dist-clean-sources when generating test data to prevent race
condition```

which implies there is something wrong with the test data creation.  That is
not accurate -- the test data script explicitly does NOT need the cleanup and
_setup_source was added specifically not do the cleanup.  I think that comment
should be changed to

```# Do not cleanup when creating self-test data```

Other than that, it looks good.
--
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to