From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3870#note_2516150047

Oops.  Somehow my comment didn't get saved.

I'd like you to think about using a common naming scheme here.  For example,
have a global RHPKG_BIN and then ifdef to set it differently when the
AUTOMOTIVE_BUILD_TARGET Makefile.variable is set.

ie) something like

RHPKG_BIN=centpkg
ifdef AUTOMOTIVE_BUILD_TARGET
  RHPKG_BIN=centpkg-sig
endif

If you did that, a lot of your changes would not be necessary IMO.

-- 
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to