From: Artem Savkov <asav...@redhat.com>

selftests/bpf: Remove ksyms_weak_lskel test

JIRA: https://issues.redhat.com/browse/RHEL-48593

Upstream status: RHEL-only

The test fails to build in Brew (as the build needs to read
/proc/kallsysm which has permission 000 in Brew builders) so disable it
until Brew builders are fixed.

Signed-off-by: Viktor Malik <vma...@redhat.com>
Signed-off-by: Artem Savkov <asav...@redhat.com>

diff --git a/tools/testing/selftests/bpf/Makefile 
b/tools/testing/selftests/bpf/Makefile
index blahblah..blahblah 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -502,7 +502,7 @@ LSKELS := fentry_test.c fexit_test.c fexit_sleep.c 
atomics.c                \
        test_ringbuf_n.c test_ringbuf_map_key.c test_ringbuf_write.c
 
 # Generate both light skeleton and libbpf skeleton for these
-LSKELS_EXTRA := test_ksyms_module.c test_ksyms_weak.c kfunc_call_test.c \
+LSKELS_EXTRA := test_ksyms_module.c kfunc_call_test.c \
        kfunc_call_test_subprog.c
 SKEL_BLACKLIST += $$(LSKELS)
 
diff --git a/tools/testing/selftests/bpf/prog_tests/ksyms_btf.c 
b/tools/testing/selftests/bpf/prog_tests/ksyms_btf.c
index blahblah..blahblah 100644
--- a/tools/testing/selftests/bpf/prog_tests/ksyms_btf.c
+++ b/tools/testing/selftests/bpf/prog_tests/ksyms_btf.c
@@ -7,7 +7,6 @@
 #include "test_ksyms_btf.skel.h"
 #include "test_ksyms_btf_null_check.skel.h"
 #include "test_ksyms_weak.skel.h"
-#include "test_ksyms_weak.lskel.h"
 #include "test_ksyms_btf_write_check.skel.h"
 
 static int duration;
@@ -111,33 +110,6 @@ static void test_weak_syms(void)
        test_ksyms_weak__destroy(skel);
 }
 
-static void test_weak_syms_lskel(void)
-{
-       struct test_ksyms_weak_lskel *skel;
-       struct test_ksyms_weak_lskel__data *data;
-       int err;
-
-       skel = test_ksyms_weak_lskel__open_and_load();
-       if (!ASSERT_OK_PTR(skel, "test_ksyms_weak_lskel__open_and_load"))
-               return;
-
-       err = test_ksyms_weak_lskel__attach(skel);
-       if (!ASSERT_OK(err, "test_ksyms_weak_lskel__attach"))
-               goto cleanup;
-
-       /* trigger tracepoint */
-       usleep(1);
-
-       data = skel->data;
-       ASSERT_EQ(data->out__existing_typed, 0, "existing typed ksym");
-       ASSERT_NEQ(data->out__existing_typeless, -1, "existing typeless ksym");
-       ASSERT_EQ(data->out__non_existent_typeless, 0, "nonexistent typeless 
ksym");
-       ASSERT_EQ(data->out__non_existent_typed, 0, "nonexistent typed ksym");
-
-cleanup:
-       test_ksyms_weak_lskel__destroy(skel);
-}
-
 static void test_write_check(bool test_handler1)
 {
        struct test_ksyms_btf_write_check *skel;
@@ -180,9 +152,6 @@ void test_ksyms_btf(void)
        if (test__start_subtest("weak_ksyms"))
                test_weak_syms();
 
-       if (test__start_subtest("weak_ksyms_lskel"))
-               test_weak_syms_lskel();
-
        if (test__start_subtest("write_check1"))
                test_write_check(true);
 

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3958

-- 
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to