oh, and while i'm here, i'm going to point out a couple other things
you should avoid if you're trying to get your first patch into the
kernel -- unsurprisingly, nick has violated both of these guidelines a
number of times.
first, good grammar. seriously, good grammar. if you can't use
proper grammar for the single-line "Subject" field, you really have no
business submitting patches.
and second, your explanation for the patch (what goes into the
commit log) should *match* the patch. in particular, do not claim that
you are fixing an "error" when all you're doing is cleaning up a
*warning*. nick is a major violator of this prime directive -- do not
categorize something as an "error" if it isn't. end of story.
and on that note, we return you to the nick krause mailing list.
enjoy.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
Kernelnewbies mailing list
[email protected]
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
