On Mon, 08 Dec 2014 14:05:45 -0700, Dean Michael Ancajas said:
> Hi,
> I have submitted single line patches. I was wondering what is the
> policy on the # of changes per patch? For instance the code below:
>
> if (Index) {
> data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAL);
> } else {
> data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAH);
> }
>
> the braces are not necessary according to the rules. Should I
>
> A. submit 1 patch for the "if" portion and another for the "else" on
> separate emails (i.e. two patches on separate emails)?
>
> B. 1 patch for the whole thing (considering this is trivial change) ?
>
> C. 2 separate patches but in 1-email only?The general rule is "one patch for one thing". In this case, "one thing" would be "fix braces" across an entire .c file (which meant that if there were 5 or 10 "if" statements that needed fixing in foo.c, you'd submit one patch that fixed all of them. But a patch that fixed leading tabs/blanks issues or too-long line issues would be a separate patch. So you'd want (B).
pgpai2kkSLZT6.pgp
Description: PGP signature
_______________________________________________ Kernelnewbies mailing list [email protected] http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
