On Sat, 08 Oct 2016 15:19:18 -0000, Nicholas Mc Guire said: > Thats actually the cause of this mail - it just becaem obvious > that some of these if==else are intentional
At the very least, the intentional ones need a comment similar to the one found in file.c > Now reporting these cases if they should be fixed makes sense > while if this is accepted practice then it would be reporting > false-positives, which would be bad. Coccinelle can only warn about things that syntactically look suspicious. The person running Coccinelle needs to have enough neurons to double-check for comments explaining the odd usage, etc - and the person creating that sort of code needs to leave some bread crumbs for people reading the code.
pgpONkz6eRKH1.pgp
Description: PGP signature
_______________________________________________ Kernelnewbies mailing list [email protected] https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
