lol, when do you sleep? you reply so quickly, and did so last time i tried too. thanks for the feedback. much appreciated!
On Mon, Jun 6, 2022 at 10:59 PM Greg KH <[email protected]> wrote: > On Mon, Jun 06, 2022 at 10:51:00PM -0700, ozzloy wrote: > > i'd like to get some feedback before sending this off to the regular > > mailing list. > > i'm following Documentation/process/submitting-patches.rst and i think > this > > is OK, but i thought that before and was wrong. > > > > i'm not even sure if i should be asking here first, or sending this to > the > > list. > > > > are there any problems with the cleanup patch below? > > it fixes something that checkpatch.pl lists as an error for pointer > > location. > > > > ========================================================================= > > >From 3ce7c7a3333aecaad6c28e0e1c17ce5b554274b0 Mon Sep 17 00:00:00 2001 > > From: Daniel Watson <[email protected]> > > Date: Mon, 6 Jun 2022 11:31:31 -0700 > > Subject: [PATCH] staging: r8188eu: fix declaration to match 'foo *bar' > > > > put '*' next to variable to match kernel style from checkpatch > > > > Signed-off-by: Daniel Watson <[email protected]> > > --- > > drivers/staging/r8188eu/include/rtw_io.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/r8188eu/include/rtw_io.h > > b/drivers/staging/r8188eu/include/rtw_io.h > > index 6910e2b430e24..0e390eda5b4d3 100644 > > --- a/drivers/staging/r8188eu/include/rtw_io.h > > +++ b/drivers/staging/r8188eu/include/rtw_io.h > > @@ -283,7 +283,7 @@ void free_io_queue(struct adapter *adapter); > > void async_bus_io(struct io_queue *pio_q); > > void bus_sync_io(struct io_queue *pio_q); > > u32 _ioreq2rwmem(struct io_queue *pio_q); > > -void dev_power_down(struct adapter * Adapter, u8 bpwrup); > > +void dev_power_down(struct adapter *Adapter, u8 bpwrup); > > > > #define PlatformEFIOWrite1Byte(_a,_b,_c) \ > > rtw_write8(_a,_b,_c) > > -- > > 2.34.1 > > Looks correct to me, send away! > > > ========================================================================= > > > > > > > > here's who i plan to send to: > > Larry Finger <[email protected]> > > Phillip Potter <[email protected]> > > Greg Kroah-Hartman <[email protected]> > > [email protected] > > Yes. > > > > > should i include this list? > > [email protected] > > If you really want to, sure. It's not required. > > > it is called a list of last resort here > > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html > > but it is in the output of get-maintainer.pl for this patch. > > It's in the output of all runs of that tool, as you say, it's the last > resort. > > good luck! > > greg k-h >
_______________________________________________ Kernelnewbies mailing list [email protected] https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
