On Tue, 5 May 2009, Jim Cromie wrote:
> On Sat, May 2, 2009 at 8:37 AM, Robert P. J. Day <[email protected]>
> wrote:
>
> i (vaguely) recall that the __setup() routine to define kernel
> boot-time parms was deprecated some time ago, but i don't
> remember
> what it was deprecated in favour of. help?
>
> rday
> --
>
>
> http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git&a=
> search&h=7b11f69fb5c475f521db79f5fa22104e15842671&st=commit&s=__setup
>
> 2nd item gave the apparent answer :
>
> [PATCH] USB: replace __setup("nousb") with __module_param_call
>
> Fedora users complain that passing "nousbstorage" to the installer causes
> the rest of the USB support to disappear. The installer uses kernel command
>
> line as a way to pass options through Syslinux. The problem stems from the
> use of strncmp() in obsolete_checksetup().
>
> I used __module_param_call() instead of module_param because I wanted to
> preserve the old syntax in grub.conf, and it's the only macro which allows
> to remove the prefix.
>
> The fix is tested to accept the option "nousb" correctly now.
>
> Signed-off-by: Pete Zaitcev <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
i don't think that qualifies as an example of why __setup() is being
deprecated (if it actually is). all the above represents is an
atypical invocation of __module_param_call() to get around a prefix
clash problem in obsolete_checksetup().
in fact, i just checked and that call isn't even there anymore.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
