On Wed, 15 Jul 2009, Daniel Baluta wrote:
> Hi Robert,
>
> You are right. The symbols marked with EXPORT_UNUSED_SYMBOL are
> deprecated and shouldn't be used by other developers. ([1]).
>
> So until they are completely removed they are marked as unused to warn
> other developers not to used them anymore.
>
> thanks
> Daniel.
>
> [1]http://lwn.net/Articles/249246/
thanks for the reference, i was looking for something like that.
it's interesting that there is only a single usage of that macro left
in the entire tree:
$ grep -r EXPORT_UNUSED_SYMBOL *
fs/libfs.c:EXPORT_UNUSED_SYMBOL(simple_prepare_write);
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL(sym) __EXPORT_SYMBOL(sym,
"_unused")
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL_GPL(sym)
__EXPORT_SYMBOL(sym, "_unused_gpl")
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL(sym)
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL_GPL(sym)
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL(sym)
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL_GPL(sym)
scripts/checkpatch.pl: ($line =~
/EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
scripts/mod/modpost.c: { .str = "EXPORT_UNUSED_SYMBOL", .export =
export_unused },
scripts/mod/modpost.c: { .str = "EXPORT_UNUSED_SYMBOL_GPL", .export =
export_unused_gpl },
that would be that single example in fs/libfs.c. what would have
been nice is if that macro had had a more descriptive name, such as
EXPORT_DEPRECATED_SYMBOL{,_GPL}, which would have made *loads* more
sense since, technically, that symbol is quite possibly *not* unused.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
"Kernel Newbie Corner" column @ linux.com: http://cli.gs/WG6WYX
========================================================================
--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to [email protected]
Please read the FAQ at http://kernelnewbies.org/FAQ
