2010/7/20 Andreas Gruenbacher <[email protected]>: > Ryan, > > On Saturday 17 July 2010 12:52:48 Ryan Wang wrote: >> Hi, >> >> I wonder when MB_CACHE_INDEXES_COUNT is undefined >> in mbcache? In mbcache.h, MB_CACHE_INDEXES_COUNT is >> set 1, so this #if always gets true. Can we remove it for it seems >> meaningless. > > This cache is currently only used to map from xattr block contents to block > numbers. The mbcache code was written so that multiple criteria like block > contents could be used, but no such user came along. Given that, I think we > can indeed get rid of some unneeded complexity here. (The difference in terms > of performance will be negligible though.) > >
Thanks for your explanations! Actually, I think the mbcache is small and operations on it won't cost too much. Maybe we can keep it here, in case some one may use it in some filesystems. -- To unsubscribe from this list: send an email with "unsubscribe kernelnewbies" to [email protected] Please read the FAQ at http://kernelnewbies.org/FAQ
