Do you think that this way of driver detection has any side effects on SMBus?
After running the system for more than 24-48 hours, the system hangs on reboot. This driver is needed for our project. On Wed, Sep 29, 2010 at 7:02 PM, Arun KS <[email protected]> wrote: > On Thu, Sep 30, 2010 at 2:45 AM, Dev Null <[email protected]> wrote: > > What are the pitfalls of using attach_adapter and detach_adapter way of > > driver detection? I know its old way and its for legacy drivers. > > This approach has to be used when you are not aware on which i2c bus > is your chip connected to. > So you have to probe on all the adapters for a particular i2c chip. > But on an embedded board, I2C bus number is known in advance. So using > the method Silesh suggested can save booting time by avoiding > unnecessary probing for the chip on all the adapters. > > Have a look here, > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/i2c/instantiating-devices > > Arun > > > I am using the i2c driver and lm sensors drivers that is also i2c driver > > through SMBus. If I run my system for longer period of time i.e. 48 > hours, > > then it hangs on reboot. Somehow, CPU doesn't get reset signal. > > > > > > On Wed, Sep 29, 2010 at 3:08 AM, Silesh C V <[email protected]> wrote: > >> > >> Hello, > >> > >> On Wed, Sep 29, 2010 at 12:57 AM, Dev Null <[email protected]> > wrote: > >> > Hello, > >> > I have been using the I2C driver and the driver detection routine > >> > through > >> > attach_adapter in that driver. In attach_adapter, I am calling > i2c_probe > >> > i2c_core call back function for the device detection. > >> > There is an another way of detecting the I2C device through probe > >> > routine > >> > and detect routine. > >> > I have looked into i2c.h and the author has mentioned that > >> > attach_adapter > >> > and detach_adapter routines are for legacy drivers. > >> > Is attach_adapter and detach_adapter way of driver detection method > okay > >> > to > >> > use? > >> > >> IMO, the simplest way is using probe/remove in struct i2c_driver and > >> use i2c_board_info and i2c_device_id to match it with your device. You > >> do not have to use attach_adapter and detach_adapter. > >> > >> > I have been getting some issue in the SMBus through i2c-core. Do you > >> > think > >> > this could be the source of that issue? > >> > >> What kind of issue ? > >> > >> Regards, > >> Silesh > > > > >
