Zhang Yanfei <[email protected]> writes:

> hole_end has been checked to make sure it is <= crash_res.end in the
> while condition check, so the if condition check is duplicate.

That test is definitely a duplicate.

Reviewed-by: "Eric W. Biederman" <[email protected]>

> Signed-off-by: Zhang Yanfei <[email protected]>
> ---
>  kernel/kexec.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 5e4bd78..c2826fc 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -497,8 +497,6 @@ static struct page 
> *kimage_alloc_crash_control_pages(struct kimage *image,
>  
>               if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
>                       break;
> -             if (hole_end > crashk_res.end)
> -                     break;
>               /* See if I overlap any of the segments */
>               for (i = 0; i < image->nr_segments; i++) {
>                       unsigned long mstart, mend;

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to