From: Cliff Wickman <[email protected]>

Make non-cyclic the default, as it is faster.

Dumping a 1TB memory is successful with a crashkernel=512M.
And allow -Y on the command line, as well as --non-cylic.

Signed-off-by: Cliff Wickman <[email protected]>
---
 makedumpfile.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Index: makedumpfile.mmap/makedumpfile.c
===================================================================
--- makedumpfile.mmap.orig/makedumpfile.c
+++ makedumpfile.mmap/makedumpfile.c
@@ -8585,13 +8585,14 @@ main(int argc, char *argv[])
        initialize_tables();
 
        /*
-        * By default, makedumpfile works in constant memory space.
+        * By default, makedumpfile makes one pass through page structures.
+        * Use --cyclic-buffer to work in constant memory space.
         */
-       info->flag_cyclic = TRUE;
+       info->flag_cyclic = FALSE;
        
        info->block_order = DEFAULT_ORDER;
        message_level = DEFAULT_MSG_LEVEL;
-       while ((opt = getopt_long(argc, argv, "b:cDd:EFfg:hi:lMpRrsvXx:", 
longopts,
+       while ((opt = getopt_long(argc, argv, "b:cDd:EFfg:hi:lMpRrsvXx:Y", 
longopts,
            NULL)) != -1) {
                switch (opt) {
                case 'A':
@@ -8694,6 +8695,8 @@ main(int argc, char *argv[])
                        break;
                case 'Z':
                        info->bufsize_cyclic = atoi(optarg);
+                       if (info->bufsize_cyclic)
+                               info->flag_cyclic = TRUE;
                        break;
                case '?':
                        MSG("Commandline parameter is invalid.\n");

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to