Re: [PATCH] kexec_core: Remove superfluous page offset handling in segment loading

[Bouron, Justinien]

On 9/11/25, 02:42, "Baoquan He" <b...@redhat.com <mailto:b...@redhat.com>> 
wrote:
> Do you mean we will adjust the memsz and buf_align to PAGE_SIZE aligned
> in kexec_add_buffer()?
That and mostly the fact that `sanity_check_segment_list()` explicitely rejects
any segment that either does not start or end on a page boundary:

int sanity_check_segment_list(struct kimage *image)
{
    // ...
    for (i = 0; i < nr_segments; i++) {
        unsigned long mstart, mend;

        mstart = image->segment[i].mem;
        mend   = mstart + image->segment[i].memsz;
        if (mstart > mend)
            return -EADDRNOTAVAIL;
        if ((mstart & ~PAGE_MASK) || (mend & ~PAGE_MASK))
            return -EADDRNOTAVAIL;
        if (mend >= KEXEC_DESTINATION_MEMORY_LIMIT)
            return -EADDRNOTAVAIL;
    }
    // ...
}

> That better be explained in log.
Does it warrant a second revision to change the log?

Thanks,
Justinien