On Sat, Nov 22, 2025 at 12:11:47PM +0100, John Paul Adrian Glaubitz wrote: > On Wed, 2025-10-22 at 13:44 +0200, John Paul Adrian Glaubitz wrote: > > Fixes the following build error on 32-bit PowerPC: > > > > kexec/arch/ppc/fs2dt.c: In function 'putnode': > > kexec/arch/ppc/fs2dt.c:338:51: error: passing argument 4 of 'scandir' from > > incompatible pointer type [-Wincompatible-pointer-types] > > 338 | numlist = scandir(pathname, &namelist, 0, comparefunc); > > | ^~~~~~~~~~~ > > | | > > | int (*)(const > > void *, const void *) > > > > Signed-off-by: John Paul Adrian Glaubitz <[email protected]> > > --- > > kexec/arch/ppc/fs2dt.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/kexec/arch/ppc/fs2dt.c b/kexec/arch/ppc/fs2dt.c > > index fed499b..d03b995 100644 > > --- a/kexec/arch/ppc/fs2dt.c > > +++ b/kexec/arch/ppc/fs2dt.c > > @@ -292,7 +292,8 @@ static void putprops(char *fn, struct dirent **nlist, > > int numlist) > > * Compare function used to sort the device-tree directories > > * This function will be passed to scandir. > > */ > > -static int comparefunc(const void *dentry1, const void *dentry2) > > +static int comparefunc(const struct dirent **dentry1, > > + const struct dirent **dentry2) > > { > > char *str1 = (*(struct dirent **)dentry1)->d_name; > > char *str2 = (*(struct dirent **)dentry2)->d_name; > > Ping for both patches.
Perhaps this email [1] got lost somehow? [1] https://lore.kernel.org/kexec/[email protected]/ FTR, they have been applied as: - kexec-tools: powerpc: Fix pointer declarations in read_memory_region_limits() https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=6c878e9b8a50 - kexec-tools: powerpc: Fix function signature of comparefunc() https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=2786f8eb3e5e
