On Thu, Apr 06, 2006 at 11:09:24AM -0700, Geoff Levand wrote: > Russel, That's Russell.
> I had some trouble with serial8250_unregister_by_port() for > ports setup by serial8250_isa_init_ports() in the KGDB > startup. > > I see in serial8250_isa_init_ports() we only assign > up->port.membase, but not up->port.mapbase, and also that > serial8250_unregister_by_port() uses uart_match_port(), which > only tests (port1->mapbase == port2->mapbase). So, I find > that serial8250_unregister_by_port() always unregisters the > port since port1.mapbase = 0, and port2.mapbase = 0. > > Now I'm wondering if the fix is to setup the mapbase between > calling serial8250_isa_init_ports() and > serial8250_unregister_by_port(), or to have uart_match_port() > test both mapbase and membase. You can't determine anything from membase because that's the ioremapped address, and for a single mapbase there may be multiple membase addresses. The only solution is to supply a proper mapbase in every case, and get rid of the legacy serial tables in asm/serial.h. -- Russell King ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
