On Sat, Sep 23, 2006 at 09:05:48PM +0400, Sergei Shtylyov wrote: > Hello. > > Tom Rini wrote: > > >>From: Dale Farnsworth <[EMAIL PROTECTED]> > > >> When implemented in inline assembly, kgdb_fault_setjmp() and > >> kgdb_fault_longjmp() fail when compiled with -fno-omit-frame-pointer. > >> This patch avoids that problem by moving them to separate assembly > >> files, arch/ppc/kernel/kgdb_misc.S and arch/powerpc/kernel/kgdb_misc.S. > > >> Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> > > >One last set of comments. Since the 32 and 64bit functions are totally > >different, lets stick them in different files. > >So like: > >ifeq ($(CONFIG_PPC32),y) > >obj-$(CONFIG_KGDB) += kgdb.o kgdb_misc32.o > >else > >obj-$(CONFIG_KGDB) += kgdb.o kgdb_misc64.o > >endif > > I'd like to suggest also to change the names to kgdb-jmp*.S (OTOH, as > more functions may appear there, the names are probably good as the are)...
Good point. -- Tom Rini ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
