Hello, I think I've found a typo in sh-lite.patch. It contains this hunk: --- cut --- Index: linux-2.6.16/drivers/serial/sh-sci.c @@ -194,18 +174,18 @@ 1: int h, l; 3: c = *p++; 4:- h = highhex(c); 5:- l = lowhex(c); 6:+ h = hexchars[c >> 4]; 7:+ l = hexchars[c % 16]; 8:[skip some context] 9:- put_char(port, highhex(checksum)); 10:- put_char(port, lowhex(checksum)); 11:+ put_char(port, hexchars[checksum >> 4]); 12:+ put_char(port, hexchars[checksum & 16]); 13: ^^^^^^^ 14: } while (get_char(port) != '+'); 15: } else 16:-#endif /* CONFIG_SH_STANDARD_BIOS || CONFIG_SH_KGDB */ --- cut ---
Line #12 seems wrong. (checksum & 16) is not functionally equivalent to lowhex(checksum). (checksum % 16), (checksum & 0xf) or even (checksum & 15) are. It's not the architecture I use nor own, can't test fixes. (Not that much testing would be needed here :-)) This information is true for: File: sh-lite.patch Status: Up-to-date Working revision: 1.28 Repository revision: 1.28 /cvsroot/kgdb/kgdb-2/sh-lite.patch,v Sticky Tag: (none) Sticky Date: (none) Sticky Options: -ko CVSROOT=:pserver:[EMAIL PROTECTED]:/cvsroot/kgdb Przemyslaw Brojewski. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
