There was no need to select CONFIG_NETPOLL* for both CONFIG_KGDBOE_NOMODULE and
CONFIG_KGDBOE as the former one selects the latter one anyway, and no need to
select CONFIG_NETPOLL_RX at all because it's just useless.

Also, undo the change to the 8139too driver hushing its complaints about the
"out-of-sync dirty pointer" -- they are actually signalling a big issue with
the netpoll's traffic trapping.

Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>

---
This patch is against linux2_6_21_uprev branch...

 drivers/net/8139too.c |    2 --
 lib/Kconfig.debug     |    4 ----
 2 files changed, 6 deletions(-)

Index: linux-2.6/drivers/net/8139too.c
===================================================================
--- linux-2.6.orig/drivers/net/8139too.c
+++ linux-2.6/drivers/net/8139too.c
@@ -1798,13 +1798,11 @@ static void rtl8139_tx_interrupt (struct
        }
 
 #ifndef RTL8139_NDEBUG
-#ifndef CONFIG_KGDBOE
        if (tp->cur_tx - dirty_tx > NUM_TX_DESC) {
                printk (KERN_ERR "%s: Out-of-sync dirty pointer, %ld vs. 
%ld.\n",
                        dev->name, dirty_tx, tp->cur_tx);
                dirty_tx += NUM_TX_DESC;
        }
-#endif /* CONFIG_KGDBOE */
 #endif /* RTL8139_NDEBUG */
 
        /* only wake the queue if we did work, and the queue is stopped */
Index: linux-2.6/lib/Kconfig.debug
===================================================================
--- linux-2.6.orig/lib/Kconfig.debug
+++ linux-2.6/lib/Kconfig.debug
@@ -513,9 +513,6 @@ config KGDB_8250_NOMODULE
 config KGDBOE_NOMODULE
        bool "KGDB: On ethernet - in kernel"
        select KGDBOE
-       select NETPOLL
-       select NETPOLL_TRAP
-       select NETPOLL_RX
        help
          Uses the NETPOLL API to communicate with the host GDB via UDP.
          In order for this to work, the ethernet interface specified must
@@ -546,7 +543,6 @@ config KGDBOE
        depends on m && KGDB
        select NETPOLL
        select NETPOLL_TRAP
-       select NETPOLL_RX
        help
          Uses the NETPOLL API to communicate with the host GDB via UDP.
          In order for this to work, the ethernet interface specified must


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to