Sergei, While I would agree with your change, I guess I had not noticed how the defaults had changed since I originally pushed this upstream.
My original intent was to have the default be "config KGDB_ONLY_MODULES". Then there is no need for the conditionals and folks who need KGDB as a built in can still have it but the default is always as a module. And then you can use kgdboe or kgdb over rs232 at runtime. I find there are only a few circumstances where KGDB is directly used as a built in. I ask the question of Sergei and anyone else, if it makes more sense to have the KGDB_ONLY_MODULES as the default? If "yes", I will make the change to have the default as using I/O modules. If "no", it makes sense to merge Sergei's change. Jason. Sergei Shtylyov wrote: > Move the non-conditional 'default KGDB_8250_NOMODULE' statement to the end of > list since otherwise the choice always defaults to it. > > Signed-off-by: Sergey Shtylyov <[EMAIL PROTECTED]> > > --- > And I thought I fixed this in August -- apparently, either Vitaly was > oblivious > to push it upstream or the patch slipped thru the cracks, like some others... > This patch goes atop of all the patchset but to apply it, you'll have to > modify > several arch-specific patches which added the 'default' statements to the > wrong > places. I'm not really sure how to handle such cases -- perhaps I should have > sent updates to each of these patches? > For review is easiest to have a patch that is on the top of the stack so the changes can be easily parsed. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
