> -----Original Message-----
> > + case 2:
> > +
> set_debugreg(breakinfo[breakno].addr, 2);
> > + break;
> > +
> > + case 3:
> > +
> set_debugreg(breakinfo[breakno].addr, 3);
> > + break;
> > + }
>
> Erm, why not replace all this switch it in one line:
If only it were that easy. set_debugreg() cannot take a variable for
second argument, which is why you have to do that.
> > + case 3:
> > +
> set_debugreg(breakinfo[breakno].addr, 3);
> > + break;
> > + }
>
> Same question here...
Same answer as above.
>
> I must note that the whole b/p mechanism has been a mess
> -- there are these {set|remove}_breakpoint() methods that
> never get called by KGDB and there are overridable
> kgdb_arch_{set|remove}_breakpoint() functions which get
> actually called. The situation was with h/w breakpoints was
> even worse -- both direct and indirect calls were in use... :-/
> I'd suggest to remove those s/w breakpoint related indirect calls.
>
Does that imply that you feel the HW breakpoint support is ok then? I
did try to make some effort to clean up the HW breakpoint access at
least to the point that it is really arch specific.
I thought that intent for the sw breakpoint routines was that an arch
could override it if needed.
Jason.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Kgdb-bugreport mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
