Hi Jason,

Sorry for not responding earlier.

On Thu, Feb 25, 2010 at 03:21:19PM -0600, Jason Wessel wrote:
> +++ b/drivers/char/kdb_keyboard.c

Does it have to live here? If you are going for completely separate
driver maybe it should be buried somewhere like xxx/kdb/kdb_keyboard.c
so nobody needs to look at it?

> diff --git a/drivers/char/kdb_keyboard.h b/drivers/char/kdb_keyboard.h
> new file mode 100644
> index 0000000..5541668
> --- /dev/null
> +++ b/drivers/char/kdb_keyboard.h
> @@ -0,0 +1,143 @@
> +/*
> + *   include/linux/pc_keyb.h
> + *
> + *   PC Keyboard And Keyboard Controller
> + *
> + *   (c) 1997 Martin Mares <[email protected]>
> + */

The above notwithstanding maybe we should not be bringing 2.4 codebase
as is in 2.6 and instead use (and extend as needed) definitions that are
already present?

-- 
Dmitry

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Kgdb-bugreport mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to