On Sat, 2010-09-25 at 15:55 +0200, Frederic Weisbecker wrote:
> > Frederic, anything we can do about that?
>
>
>
> Jason's patch is partially good, it just lacks one place to handle.
> Jiri, can you test that?
>
> diff --git a/kernel/hw_breakpoint.c b/kernel/hw_breakpoint.c
> index d71a987..d727c58 100644
> --- a/kernel/hw_breakpoint.c
> +++ b/kernel/hw_breakpoint.c
> @@ -134,7 +134,7 @@ fetch_bp_busy_slots(struct bp_busy_slots *slots, struct
> perf_event *bp,
> enum bp_type_idx type)
> {
> int cpu = bp->cpu;
> - struct task_struct *tsk = bp->ctx->task;
> + struct task_struct *tsk = bp->ctx ? bp->ctx->task : NULL;
>
> if (cpu >= 0) {
> slots->pinned = per_cpu(nr_cpu_bp_pinned[type], cpu);
> @@ -213,7 +213,7 @@ toggle_bp_slot(struct perf_event *bp, bool enable, enum
> bp_type_idx type,
> int weight)
> {
> int cpu = bp->cpu;
> - struct task_struct *tsk = bp->ctx->task;
> + struct task_struct *tsk = bp->ctx ? bp->ctx->task : NULL;
>
> /* Pinned counter cpu profiling */
> if (!tsk) {
That's identical to writing *tsk = NULL;
You seem to be missing the detail that perf_event->ctx will _always_ be
NULL during pmu::event_init()
> > That'll probably screw over some accounting, not sure what tsk is used
> > for there.
>
>
> Nope it's ok. tsk is used to know if we are dealing with
> a task/cpu bound breakpoint or a cpu wide bound one.
>
> If tsk ends up being NULL, it will think it's a cpu wide bound
> breakpoint, which it is in the case of kgdb breakpoints.
See above, there's currently no way to know that in pmu::event_init().
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Kgdb-bugreport mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
