On Mon, May 30, 2011 at 05:51, Sergei Shtylyov wrote: > On 28-05-2011 18:04, Mike Frysinger wrote: >> The new instruction_pointer_set helper is defined for people who have >> converted to asm-generic/ptrace.h, so don't use it generally unless >> the arch needs it (in which case it has been converted). This should >> fix building of kgdb tests for arches not yet converted. > >> --- a/drivers/misc/kgdbts.c >> +++ b/drivers/misc/kgdbts.c >> @@ -304,7 +304,10 @@ static int check_and_rewind_pc(char *put_str, char >> *arg) >> return 1; >> } >> /* Readjust the instruction pointer if needed */ >> - instruction_pointer_set(&kgdbts_regs, ip + offset); >> + ip += offset; > > Since 'íp' is local, incrementing it is pointless here unless you have > GDB_ADJUSTS_BREAK_OFFSET defined. Why not keep instruction_pointer_set() > call as is?
i prefer to have as much outside of ifdefs as possible. gcc optimizes the result away, so it isnt a code size problem. -mike ------------------------------------------------------------------------------ vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
