On 09/22/2011 03:46 PM, Tim Bird was caught saying: > On 09/22/2011 01:34 PM, George Anzinger wrote: >> I learned a long time ago that if you have to put special words in the >> messages or the manual there is something wrong with the code. >> >> Surely there is a way to poke through the write protection, after all >> the kernel does. > I'm not sure I understand your comment about special words. > > This patch has nothing to do with the other one I posted. That one > related to the text segment of the kernel being write-protected. > This one corrects a simple bug, where a function pointer is used > uninitialized. > > Maybe you intended to respond to the other patch?
Yes, that is the one. Sorry about the confusion. > > Assuming that, I'm open to the idea of having it just "work", > as opposed to a lame message saying to re-compile. Seem like the thing to do to me. -- George > -- Tim > >> On 09/21/2011 02:19 PM, Tim Bird was caught saying: >>> This fixes a bug with setting a breakpoint during kdb initialization >>> (from kdb_cmds). Any call to kdb_printf() before the initialization >>> of the kgdboc serial console driver (which happens much later during >>> bootup than kdb_init), results in kernel panic due to the use of >>> dbg_io_ops before it is initialized. >>> >>> Signed-off-by: Tim Bird<[email protected]> >>> --- >>> kernel/debug/kdb/kdb_io.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c >>> index c9b7f4f..3bc995f 100644 >>> --- a/kernel/debug/kdb/kdb_io.c >>> +++ b/kernel/debug/kdb/kdb_io.c >>> @@ -675,7 +675,7 @@ kdb_printit: >>> if (!dbg_kdb_mode&& kgdb_connected) { >>> gdbstub_msg_write(kdb_buffer, retlen); >>> } else { >>> - if (!dbg_io_ops->is_console) { >>> + if (dbg_io_ops&& !dbg_io_ops->is_console) { >>> len = strlen(kdb_buffer); >>> cp = kdb_buffer; >>> while (len--) { > -- George Anzinger [email protected] ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
