Hi,

----- Original Message -----
> From: "Jason Wessel" <[email protected]>
> To: "Andrei Warkentin" <[email protected]>
> Cc: [email protected], [email protected]
> Sent: Sunday, February 26, 2012 8:58:37 AM
> Subject: Re: [PATCH] KDB: Fix usability issues relating to the 'enter' key.

> 
> Andrei, if you agree with the attached patch, I'll put it in the
> merge queue.  If you find problems we can go another iteration. :-)
>

Nak. As I've mentioned in my original email, I went down this route as well, 
only
to ask the question of why the special ENTER code was there, since all it did
was introduce problems elsewhere (like repeat ENTER handling, KP ENTER key...).
This is exactly why my solution was to get rid of the special ENTER code 
altogether.

The code in kgdboc already will do input device reset on kdb exit, so there is 
no need
to explicitely empty out the keyboard FIFO on every ENTER.

Thanks,
A

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Kgdb-bugreport mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to