(2012/03/23 23:38), Jason Wessel wrote: > On 03/23/2012 09:08 AM, Masami Hiramatsu wrote: >> (2012/03/22 20:57), Jason Wessel wrote: >>> I will use the arch specific provision to override the >>> kgdb_arch_set_breakpoint() and use the text_poke() directly. >> >> Thanks! that's what I meant. You can use __weak attribute. >> > > I created and tested a patch yesterday which is show below. I will > post a new series at some point soon which addresses this problem as > well as a number of problems found with the kgdb test suite.
Yeah, that's better. BTW, I'm not sure the policy of kgdb about mutex, but it seems that you need to hold a text_mutex when you call the text_poke() since it uses a fixmap page-area for mapping read-only text page to writable page. So, without locking (at least ensuring no one using) text_mutex, it seems not be safe. (some other code may be trying to change the code by using same fixmap pages) Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: [email protected] ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
