Hi Douglas, On 2020/5/14 7:41, Doug Anderson wrote:
>> - } >> + } else if (strcmp(argv[1], "KDBFLAGS") == 0) >> + return KDB_NOPERM; > > One slight nit is that my personal preference is that if one half of > an "if/else" needs braces then both halves should have braces. I Thanks for spotting it. Refer to Documentation/process/coding-style.rst, i will fix it in the v2. > don't know what Daniel and Jason's policies are, though. In any case, > not that I've ever used the KDBDEBUG functionality, but your change > seems sane. Without it if I set "KDBDEBUG" and "KDBFLAGS" and then > type "env" I see the flags listed twice, but one is real and one is > fake. > > Reviewed-by: Douglas Anderson <diand...@chromium.org> > > -Doug > Thanks, Wei _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport