On Fri, 17 Jul 2020 04:48:52 +0800 kernel test robot <l...@intel.com> wrote:
> Hi Daniel, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on kgdb/kgdb-next pmladek/for-next v5.8-rc5 > next-20200716] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Daniel-Thompson/kgdb-Honour-the-kprobe-blacklist-when-setting-breakpoints/20200716-232506 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > f8456690ba8eb18ea4714e68554e242a04f65cff > config: arm64-allyesconfig (attached as .config) > compiler: aarch64-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross > ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <l...@intel.com> > > All errors (new ones prefixed by >>): > > >> drivers/net/wireless/intel/ipw2x00/ipw2100.c:3794:16: error: conflicting > >> types for 'show_registers' > 3794 | static ssize_t show_registers(struct device *d, struct > device_attribute *attr, > | ^~~~~~~~~~~~~~ > In file included from include/linux/kgdb.h:19, > from arch/arm64/include/asm/cacheflush.h:11, > from include/linux/highmem.h:12, > from include/linux/pagemap.h:11, > from include/linux/blkdev.h:16, > from include/linux/blk-cgroup.h:23, > from include/linux/writeback.h:14, > from include/linux/memcontrol.h:22, > from include/net/sock.h:53, > from include/linux/tcp.h:19, > from drivers/net/wireless/intel/ipw2x00/ipw2100.c:144: > include/linux/kprobes.h:230:13: note: previous declaration of > 'show_registers' was here > 230 | extern void show_registers(struct pt_regs *regs); > | ^~~~~~~~~~~~~~ It seems this function had been introduced before git, and forgot to removed from kprobes.h. OK, commit 57da8b960b9a ("x86: Avoid double stack traces with show_regs()") renamed show_registers() to show_regs() but forgot to remove old prototype in kprobes.h. Anyway, we should remove it because kprobes doesn't use it anymore. Thank you, -- Masami Hiramatsu <mhira...@kernel.org> _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
