Better to replace function name by %s in case of changes.

Signed-off-by: Stephen Zhang <stephenzhang...@gmail.com>
---
 kernel/debug/kdb/kdb_support.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
index 6226502..7a536fc 100644
--- a/kernel/debug/kdb/kdb_support.c
+++ b/kernel/debug/kdb/kdb_support.c
@@ -40,19 +40,19 @@
 int kdbgetsymval(const char *symname, kdb_symtab_t *symtab)
 {
        if (KDB_DEBUG(AR))
-               kdb_printf("kdbgetsymval: symname=%s, symtab=%px\n", symname,
+               kdb_printf("%s: symname=%s, symtab=%px\n", __func__, symname,
                           symtab);
        memset(symtab, 0, sizeof(*symtab));
        symtab->sym_start = kallsyms_lookup_name(symname);
        if (symtab->sym_start) {
                if (KDB_DEBUG(AR))
-                       kdb_printf("kdbgetsymval: returns 1, "
+                       kdb_printf("%s: returns 1, "
                                   "symtab->sym_start=0x%lx\n",
-                                  symtab->sym_start);
+                                   __func__, symtab->sym_start);
                return 1;
        }
        if (KDB_DEBUG(AR))
-               kdb_printf("kdbgetsymval: returns 0\n");
+               kdb_printf("%s: returns 0\n", __func__);
        return 0;
 }
 EXPORT_SYMBOL(kdbgetsymval);
@@ -88,15 +88,15 @@ int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
        char *knt1 = NULL;
 
        if (KDB_DEBUG(AR))
-               kdb_printf("kdbnearsym: addr=0x%lx, symtab=%px\n", addr, 
symtab);
+               kdb_printf("%s: addr=0x%lx, symtab=%px\n", __func__, addr, 
symtab);
        memset(symtab, 0, sizeof(*symtab));
 
        if (addr < 4096)
                goto out;
        knt1 = debug_kmalloc(knt1_size, GFP_ATOMIC);
        if (!knt1) {
-               kdb_printf("kdbnearsym: addr=0x%lx cannot kmalloc knt1\n",
-                          addr);
+               kdb_printf("%s: addr=0x%lx cannot kmalloc knt1\n",
+                           __func__, addr);
                goto out;
        }
        symtab->sym_name = kallsyms_lookup(addr, &symbolsize , &offset,
@@ -148,10 +148,10 @@ int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
        if (symtab->mod_name == NULL)
                symtab->mod_name = "kernel";
        if (KDB_DEBUG(AR))
-               kdb_printf("kdbnearsym: returns %d symtab->sym_start=0x%lx, "
-                  "symtab->mod_name=%px, symtab->sym_name=%px (%s)\n", ret,
-                  symtab->sym_start, symtab->mod_name, symtab->sym_name,
-                  symtab->sym_name);
+               kdb_printf("%s: returns %d symtab->sym_start=0x%lx, "
+                  "symtab->mod_name=%px, symtab->sym_name=%px (%s)\n",
+                   __func__, ret, symtab->sym_start, symtab->mod_name,
+                  symtab->sym_name, symtab->sym_name);
 
 out:
        debug_kfree(knt1);
@@ -328,7 +328,7 @@ int kdb_getarea_size(void *res, unsigned long addr, size_t 
size)
        int ret = copy_from_kernel_nofault((char *)res, (char *)addr, size);
        if (ret) {
                if (!KDB_STATE(SUPPRESS)) {
-                       kdb_printf("kdb_getarea: Bad address 0x%lx\n", addr);
+                       kdb_printf("%s: Bad address 0x%lx\n", __func__, addr);
                        KDB_STATE_SET(SUPPRESS);
                }
                ret = KDB_BADADDR;
@@ -353,7 +353,7 @@ int kdb_putarea_size(unsigned long addr, void *res, size_t 
size)
        int ret = copy_from_kernel_nofault((char *)addr, (char *)res, size);
        if (ret) {
                if (!KDB_STATE(SUPPRESS)) {
-                       kdb_printf("kdb_putarea: Bad address 0x%lx\n", addr);
+                       kdb_printf("%s: Bad address 0x%lx\n", __func__, addr);
                        KDB_STATE_SET(SUPPRESS);
                }
                ret = KDB_BADADDR;
@@ -435,7 +435,7 @@ int kdb_getphysword(unsigned long *word, unsigned long 
addr, size_t size)
                fallthrough;
        default:
                diag = KDB_BADWIDTH;
-               kdb_printf("kdb_getphysword: bad width %ld\n", (long) size);
+               kdb_printf("%s: bad width %ld\n", __func__, (long) size);
        }
        return diag;
 }
@@ -484,7 +484,7 @@ int kdb_getword(unsigned long *word, unsigned long addr, 
size_t size)
                fallthrough;
        default:
                diag = KDB_BADWIDTH;
-               kdb_printf("kdb_getword: bad width %ld\n", (long) size);
+               kdb_printf("%s: bad width %ld\n", __func__, (long) size);
        }
        return diag;
 }
@@ -528,7 +528,7 @@ int kdb_putword(unsigned long addr, unsigned long word, 
size_t size)
                fallthrough;
        default:
                diag = KDB_BADWIDTH;
-               kdb_printf("kdb_putword: bad width %ld\n", (long) size);
+               kdb_printf("%s: bad width %ld\n", __func__, (long) size);
        }
        return diag;
 }
-- 
1.8.3.1



_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to