On Thu 2021-02-25 21:24:34, John Ogness wrote: > All 6 kmsg_dumpers do not benefit from the @active flag: > > (provide their own synchronization) > - arch/powerpc/kernel/nvram_64.c > - arch/um/kernel/kmsg_dump.c > - drivers/mtd/mtdoops.c > - fs/pstore/platform.c > > (only dump on KMSG_DUMP_PANIC, which does not require > synchronization) > - arch/powerpc/platforms/powernv/opal-kmsg.c > - drivers/hv/vmbus_drv.c > > The other 2 kmsg_dump users also do not rely on @active: > > (hard-code @active to always be true) > - arch/powerpc/xmon/xmon.c > - kernel/debug/kdb/kdb_main.c
Great summary! > Therefore, @active can be removed. > > Signed-off-by: John Ogness <john.ogn...@linutronix.de> Reviewed-by: Petr Mladek <pmla...@suse.com> Best Regards, Petr _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
