On Wed, May 17, 2023 at 02:54:09PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <a...@arndb.de> > > kdb_send_sig() is defined in the signal code and called from kdb, > but the declaration is part of the kdb internal code. > Include this from signal.c as well to avoid the warning: > > kernel/signal.c:4789:6: error: no previous prototype for 'kdb_send_sig' > [-Werror=missing-prototypes] > > Signed-off-by: Arnd Bergmann <a...@arndb.de>
Sorry to be so late with this feedback! I got as far as queuing this up for merge before the penny dropped... > --- > kernel/signal.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/signal.c b/kernel/signal.c > index 8f6330f0e9ca..d38df14f71ac 100644 > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -4780,6 +4780,8 @@ void __init signals_init(void) > > #ifdef CONFIG_KGDB_KDB > #include <linux/kdb.h> > +#include "debug/kdb/kdb_private.h" > + Isn't is better to move the prototype for kdb_send_sig() into linux/kdb.h instead? That's what other kdb helpers spread across the kernel do (kdb_walk_kallsyms() for example). Daniel. _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
